[FFmpeg-devel] [PATCH] Make video_thread return a meaningful error value.

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> On Sun, Jan 30, 2011 at 1:13 PM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
>> ---
>> ?ffplay.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/ffplay.c b/ffplay.c
>> index 64b069f..c254bde 100644
>> --- a/ffplay.c
>> +++ b/ffplay.c
>> @@ -1905,7 +1905,7 @@ static int video_thread(void *arg)
>> ? ? av_freep(&is->vgraph);
>> ?#endif
>> ? ? av_free(frame);
>> - ? ?return 0;
>> + ? ?return ret;
>> ?}
>>
>> ?static int subtitle_thread(void *arg)
>> --
>> 1.7.2.3
>
> Why? We're not using the return value anywhere... (Don't forget, this
> is a thread, you need to catch the return value with some magic
> pthread calls.)

And that's wrapped up in SDL obscurity in this case.

-- 
M?ns Rullg?rd
mans at mansr.com