[FFmpeg-devel] [PATCH] Make ffmpeg warns the user when the selected sample format is ignored.

[Stefano Sabatini]

On date Friday 2011-01-28 00:02:08 +0000, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> 
> > ---
> >  ffmpeg.c |    8 +++++++-
> >  1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 691b73e..58d13ae 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -600,8 +600,14 @@ static void choose_sample_fmt(AVStream *st, AVCodec *codec)
> >              if(*p == st->codec->sample_fmt)
> >                  break;
> >          }
> > -        if(*p == -1)
> > +        if (*p == -1) {
> > +            av_log(NULL, AV_LOG_WARNING,
> > +                   "Invalid sample format '%s' in stream format '%s', selecting format '%s'\n",
> 
> I'm not so sure about using "invalid" here.  Wouldn't "incompatible"
> or something in that direction be more appropriate?
> 
> > +                   av_get_sample_fmt_name(st->codec->sample_fmt),
> > +                   codec->name,
> > +                   av_get_sample_fmt_name(codec->sample_fmts[0]));
> >              st->codec->sample_fmt = codec->sample_fmts[0];
> > +        }
> >      }
> >  }
> 
> Looks good otherwise.

Updated.
-- 
FFmpeg = Freak & Fantastic MultiPurpose Eretic Gadget