[FFmpeg-devel] [PATCH] Document that av_write_header can change stream time_base.

[Reimar Döffinger]

On Sat, Jan 29, 2011 at 05:01:17AM -0800, Baptiste Coudurier wrote:
> On 1/29/11 4:54 AM, Reimar D?ffinger wrote:
> > ---
> >  libavformat/avformat.h |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> > index f9f9be5..5e01922 100644
> > --- a/libavformat/avformat.h
> > +++ b/libavformat/avformat.h
> > @@ -507,6 +507,8 @@ typedef struct AVStream {
> >       * This is the fundamental unit of time (in seconds) in terms
> >       * of which frame timestamps are represented. For fixed-fps content,
> >       * time base should be 1/framerate and timestamp increments should be 1.
> > +     * decoding: set by libavformat
> > +     * encoding: set by user, possibly modified by libavformat in av_write_header
> >       */
> 
> Setting time_base in AVStream when muxing doesn't work directly.
> User has to use AVCodecContext->time_base, which is used to specify the
> frame rate usually, for VFR set it to arbitrary large denominator value.

I have the feeling this is a huge hack that was used only because it worked
better in FFmpeg not because it makes sense. But whatever.
Is there a way to reply to review and send in a new patch without having to
send two emails? This seems annoyingly inefficent and discourages actually
discussing reviews.