[FFmpeg-devel] Fwd: framebuffer device demuxer

[Diego Biurrun]

On Fri, Jan 28, 2011 at 11:28:43PM +0100, Stefano Sabatini wrote:
> 
> Updated patch, not all the comments addressed (especially for the
> varinfo/fixinfo stuff) so not yet ready for commit.
> 
> --- a/configure
> +++ b/configure
> @@ -1395,6 +1395,7 @@ alsa_indev_deps="alsa_asoundlib_h snd_pcm_htimestamp"
>  alsa_outdev_deps="alsa_asoundlib_h"
>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>  dv1394_indev_deps="dv1394 dv_demuxer"
> +linuxfb_indev_deps="linux_fb_h"
>  jack_indev_deps="jack_jack_h"
>  libdc1394_indev_deps="libdc1394"
>  oss_indev_deps_any="soundcard_h sys_soundcard_h"

order

> --- a/doc/indevs.texi
> +++ b/doc/indevs.texi
> @@ -112,6 +112,30 @@ For more information read:
>  
>  IIDC1394 input device, based on libdc1394 and libraw1394.
>  
> + at section linuxfb
> +
> +Linux framebuffer input device.
> +
> +The name of the framebuffer device to read is a file device node,
> +usually @file{/dev/fb0}.

This is a little too quick.  IMO the first paragraph of such a description
should serve to tell a completely clueless reader what this linuxfb thing
is all about.  Such a reader would not yet know from the first sentence
that this linuxfb thing reads from file nodes.

> +For more detailed information related to the Linux framebuffer device
> +read the file kernel/Documentation/fb/framebuffer.txt included in
> +Linux.

The "Documentation" directory resides at the top level of the Linux
sources, not below "kernel".

> --- /dev/null
> +++ b/libavdevice/linuxfb.c
> @@ -0,0 +1,240 @@
> +
> +av_cold static int linuxfb_read_header(AVFormatContext *avctx, AVFormatParameters *ap)

nit: Here and in other places some lines could easily be shortened.

> +    /* wait based on the frame rate */
> +    while (1) {
> +        curtime = av_gettime();
> +        delay = fb->time_frame - curtime;
> +#ifdef DEBUG
> +        av_log(avctx, AV_LOG_DEBUG,
> +               "time_frame:%"PRId64" curtime:%"PRId64" delay:%"PRId64"\n",
> +               fb->time_frame, curtime, delay);
> +#endif

dprintf

Diego