[FFmpeg-devel] [PATCH] Allow overriding SAMPLES path from make command

[Baptiste Coudurier]

On 1/28/11 10:54 PM, Reimar D?ffinger wrote:
> On 29 Jan 2011, at 05:36, M?ns Rullg?rd <mans at mansr.com> wrote:
>> Reinhard Tartler <siretart at tauware.de> writes:
>> 
>>> On Sat, Jan 29, 2011 at 00:07:26 (CET), Diego Biurrun wrote:
>>> 
>>>> On Sat, Jan 29, 2011 at 12:02:36AM +0100, Reimar D?ffinger
>>>> wrote:
>>>>> On 28 Jan 2011, at 21:32, M?ns Rullg?rd <mans at mansr.com>
>>>>> wrote:
>>>>>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>>>>>> 
>>>>>>> --- a/configure +++ b/configure @@ -3243,7 +3243,7 @@
>>>>>>> SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD} 
>>>>>>> SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD} 
>>>>>>> SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD} 
>>>>>>> SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD} 
>>>>>>> -SAMPLES=$samples +SAMPLES?=$samples EOF
>>>>>>> 
>>>>>>> get_version(){
>>>>>> 
>>>>>> This, like any other make variable, can already be
>>>>>> overridden on the command line.
>>>>> 
>>>>> Ops, I messed up the description. It allows overriding it
>>>>> with an environment variable.
>>>> 
>>>> Elaborate - does 'make SAMPLES=foo' not work?
>>> 
>>> I guess Raimar's patch intends to make 'SAMPLES=foo make' work
>> 
>> What's the point?
> 
> It means I can put it in my .profile and don't have to remember to
> specify it at every configure run. I can then also move the samples
> without having to reconfigure or specify it explicitly on each make
> fate. A better implementation would probably be not to emit the
> SAMPLES= at all when $samples is not set, but I that seemed a bit
> ugly in implementation.

Yes, I would find that very useful as well.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org