[FFmpeg-devel] [FFmpeg-commits] os: replace select with poll

Ronald S. Bultje rsbultje
Fri Jan 28 17:12:12 CET 2011


Hi

On Fri, Jan 28, 2011 at 9:59 AM, Luca Barbato <git at ffmpeg.org> wrote:
> --- a/libavformat/rtsp.h
> +++ b/libavformat/rtsp.h
> @@ -326,6 +326,11 @@ typedef struct RTSPState {
> ? ? ?* The number of returned packets
> ? ? ?*/
> ? ? uint64_t packets;
> +
> + ? ?/**
> + ? ? * Polling array for udp
> + ? ? */
> + ? ?struct pollfd *p;
> ?} RTSPState;
>
> ?/**

"p" in a struct sucks, can you rename it to something a little bigger?

Also, you only updated the UDP code to use this, but allocate it for
TCP also, can you either not allocate it or use it for TCP also?

Ronald



More information about the ffmpeg-devel mailing list