[FFmpeg-devel] [PATCH 1/2] Remove the add bias hack for the C version of DSPContext.float_to_int16_*().

[Justin Ruggles]

On 01/27/2011 12:12 PM, Alex Converse wrote:

> On Thu, Jan 27, 2011 at 7:20 AM, Justin Ruggles
> <justin.ruggles at gmail.com> wrote:
>> ---
>>  libavcodec/aac.h           |    1 -
>>  libavcodec/aacdec.c        |   42 +++++++++++++++------------------------
>>  libavcodec/aacsbr.c        |   13 ++---------
>>  libavcodec/ac3dec.c        |   13 +----------
>>  libavcodec/ac3dec.h        |    1 -
>>  libavcodec/binkaudio.c     |    5 ----
>>  libavcodec/dca.c           |   47 +++++++++++++++++--------------------------
>>  libavcodec/dsputil.c       |    9 +-------
>>  libavcodec/dsputil.h       |    3 +-
>>  libavcodec/nellymoserdec.c |    9 +-------
>>  libavcodec/vorbis_dec.c    |   38 ++++++++---------------------------
>>  libavcodec/wmadec.c        |   21 +-----------------
>>  12 files changed, 54 insertions(+), 148 deletions(-)
>>
> 
> There are some further improvements you could make if you wanted to go
> above and beyond like subbing in memcpy()s and checking if
> dspfunctions fit new simplified loop calculations but this *looks* OK
> as is.

I just wanted to cover the minimum of what was needed for this change
for now.  I did change one function for a memcpy() in vorbis_dec.c, but
maybe there are more I missed since I'm not familiar with all these
decoders in detail.

> What kind of testing did you do?


make fate plus some manual ac3 and dts downmixing tests (ac3 5.1 to
stereo, ac3 5.1 to mono, and dts 5.1 to stereo).  all tests pass with
and without --disable-mmx.

-Justin