[FFmpeg-devel] [PATCH 1/2] Remove the add bias hack for the C version of DSPContext.float_to_int16_*().

Alex Converse alex.converse
Thu Jan 27 18:03:21 CET 2011


2011/1/27 M?ns Rullg?rd <mans at mansr.com>:
> Justin Ruggles <justin.ruggles at gmail.com> writes:
>
>> ---
>> ?libavcodec/aac.h ? ? ? ? ? | ? ?1 -
>> ?libavcodec/aacdec.c ? ? ? ?| ? 42 +++++++++++++++------------------------
>> ?libavcodec/aacsbr.c ? ? ? ?| ? 13 ++---------
>> ?libavcodec/ac3dec.c ? ? ? ?| ? 13 +----------
>> ?libavcodec/ac3dec.h ? ? ? ?| ? ?1 -
>> ?libavcodec/binkaudio.c ? ? | ? ?5 ----
>> ?libavcodec/dca.c ? ? ? ? ? | ? 47 +++++++++++++++++--------------------------
>> ?libavcodec/dsputil.c ? ? ? | ? ?9 +-------
>> ?libavcodec/dsputil.h ? ? ? | ? ?3 +-
>> ?libavcodec/nellymoserdec.c | ? ?9 +-------
>> ?libavcodec/vorbis_dec.c ? ?| ? 38 ++++++++---------------------------
>> ?libavcodec/wmadec.c ? ? ? ?| ? 21 +-----------------
>> ?12 files changed, 54 insertions(+), 148 deletions(-)
>
> Are you reasonably confident you've tested all the modified code?
> Does fate cover e.g. AAC-SBR? ?(If not, that should be fixed of course.)
>

Indeed SBR does have coverage:
http://git.ffmpeg.org/?p=ffmpeg.git;a=blob;f=tests/fate/aac.mak

Regards,
Alex



More information about the ffmpeg-devel mailing list