[FFmpeg-devel] Donations and what happens with them

[Ronald S. Bultje]

Hi,

On Wed, Jan 26, 2011 at 1:28 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Wed, Jan 26, 2011 at 07:18:48PM +0100, Diego Biurrun wrote:
>> On Wed, Jan 26, 2011 at 07:08:16PM +0100, Reimar D?ffinger wrote:
>> > > Anyway, we don't want to kick you or anyone else away. We just want to
>> > > do away with some old habits of development and replace them with - we
>> > > think - better ones.
>> >
>> > I'd still like to know what everyone thinks are those better ones are.
>> > Because what I have seen happening is:
>> >
>> > - You said you'd require ok by two developers, essentially doubling review
>> > ? effort for all external patches.
>>
>> Where did you get this idea?
>
> From this:
>
> - All changes shall be reviewed and approved by at least one other
> ?developer
>
> The alternative is that a rule for external contributions was never
> mentioned at all...

Just to make this crystal-clear:
- outside contributions will be reviewed by a reviewer, and applied once OK'ed
- to prevent people with direct commit access from applying stuff
without review (which has happened repeatedly in the past),
contributions from committers shall be reviewed by another reviewer
before being applied

Review happens similar as previously: if there's comments by any
expert person, then the patch can be resubmitted after these have been
addressed. Everyone is encouraged to help review. A reviewer does not
have to be a committer. However, in the end one committer will always
(at least briefly) review your patch, because he's the one applying
it.

Ronald