[FFmpeg-devel] [FFmpeg-commits] mov: simplify mov_read_chapters() by using avio_get_str16be

[Ronald S. Bultje]

Hi,

On Wed, Jan 26, 2011 at 5:28 PM, Anton Khirnov <anton at khirnov.net> wrote:
> On Wed, Jan 26, 2011 at 10:22:41AM -0800, John Stebbins wrote:
>> On 01/26/2011 09:55 AM, Ronald S. Bultje wrote:
>> > Hi,
>> >
>> > On Wed, Jan 26, 2011 at 1:15 AM, John Stebbins <stebbins at jetheaddev.com> wrote:
>> >> On 01/25/2011 02:37 PM, John Stebbins wrote:
>> >>> On 01/25/2011 12:47 PM, Anton Khirnov wrote:
>> >>>> Module: ffmpeg
>> >>>> Branch: master
>> >>>> Commit: c34461b35b68ff1f3d04540e0279383c51be8cee
>> >>>>
>> >>>> Author: Anton Khirnov<anton at khirnov.net>
>> >>>> Date: ? Sun Jan 23 12:38:30 2011 +0100
>> >>>>
>> >>>> mov: simplify mov_read_chapters() by using avio_get_str16be
>> >>>>
>> >>>> It probably also fixes a memleak or two.
>> >>>>
>> >>>> Signed-off-by: Janne Grunau<janne-ffmpeg at jannau.net>
>> >>>>
>> >>>>
>> >>> I don't suppose you would be willing to make this work with little-endian
>> >>> utf16 chapter names as well. I've seen an
>> >>> mp4with such names that this (and the previous implementation) would choke
>> >>> on. I can supply the sample if needed.
>> >> Here's a patch to that works for us. It's pretty straight forward.
>> > Can you provide the sample? Patch looks ok in principle if this
>> > happens in the wild.
>> >
>> >
>> Uploaded to ftp://ffmpeg.org/MPlayer/incoming/mov_utf16le_chapters/mov_utf16le_chapters.mov
> Tested, patch works for me.

Patch OK then.

Ronald