[FFmpeg-devel] Fwd: framebuffer device demuxer

[Stefano Sabatini]

On date Wednesday 2011-01-26 23:56:05 +0100, Diego Biurrun encoded:
> On Wed, Jan 26, 2011 at 11:18:38PM +0100, Stefano Sabatini wrote:
> > On date Wednesday 2011-01-26 10:55:56 +0100, Diego Biurrun encoded:
> > > On Tue, Jan 25, 2011 at 11:47:35PM +0100, Stefano Sabatini wrote:
> > > > 
> > > > --- /dev/null
> > > > +++ b/libavdevice/framebuffer.c
> > > > @@ -0,0 +1,220 @@
> > > > +
> > > > +/**
> > > > + * @file
> > > > + * Linux Frame Buffer input device
> > > 
> > > framebuffer
> > > 
> > > > + * Based on code from fbgrab.c by Gunnar Monell.
> > > 
> > > What license was that code?
> > 
> > GPL, I concluded that there is not enough code in common to impose the
> > use of GPL, though I have no problem at re-licensing the file under
> > GPL if someone insists on this.
> 
> Your "based on" wording suggests more than that.  This is dangerous
> territory, which parts are based on what?  If you want to be absolutely
> sure, you could ask Gunnar to allow you to use his code under LGPL.
> 
> > --- /dev/null
> > +++ b/libavdevice/framebuffer.c
> > @@ -0,0 +1,216 @@
> > +
> > +/**
> > + * Initialize the fb grab device demuxer (public device demuxer API).
> > + */
> > +av_cold static int frame_buffer_read_header(AVFormatContext *avctx, AVFormatParameters *ap)
> 
> nit: You could rename all those "frame_buffer_" functions to
> "framebuffer_".
> 
> > +    fb->frame_linesize = fb_varinfo.xres * ((bits_per_pixel + 7)>>3);
> 
> nit: 7)>>3 ---> 7) >> 3

All nits fixed.
-- 
FFmpeg = Frightening & Fanciful Maxi Perennial Elitist Goblin