[FFmpeg-devel] [PATCH] Replace defines in libavformat/mpegtsenc.c with AVOptions

[Ronald S. Bultje]

Hi,

2011/1/25 Georgi Chorbadzhiyski <gf at unixsol.org>:
> Please see the attached patch. It is generated on top of
> "Prevent unused variable warning in libavformat/mpegtsenc.c"
[..]
> This patch adds support for setting transport_stream_id,
> original_network_id, service_id, pmt_start_pid and start_pid
> in mpegts muxer.
>
> Example usage:
> ? ffmpeg -i ffmpeg.mpg -acodec copy -vcodec copy \
> ? ? ? ?-mpegts_transport_stream_id 0x1122 \
> ? ? ? ?-mpegts_original_network_id 0x3344 \
> ? ? ? ?-mpegts_service_id 0x5566 \
> ? ? ? ?-mpegts_pmt_start_pid 0x1500 \
> ? ? ? ?-mpegts_start_pid 0x150 \
> ? ? ? ?-y ffmpeg.ts
[..]
> ?#define DEFAULT_PROVIDER_NAME ? "FFmpeg"
> ?#define DEFAULT_SERVICE_NAME ? ?"Service01"

I'm probably being an ass here, but A) wouldn't some documentation on
what these values are help a lot here? Maybe a RFC reference or
something. Also, wouldn't it help to be able to set PROVIDER_NAME or
SERVICE_NAME also while you're at it?

Ronald