[FFmpeg-devel] [PATCH] Use the explicit version of add instruction in snowdsp_mmx.c

[İsmail Dönmez]

Hi;

2011/1/26 M?ns Rullg?rd <mans at mansr.com>

> ?smail D?nmez <ismail at namtrac.org> writes:
>
> > Hi;
> >
> > 2011/1/26 M?ns Rullg?rd <mans at mansr.com>
> >
> >> Ismail D?nmez <ismail at namtrac.org> writes:
> >>
> >> > Hi;
> >> >
> >> > Fixes compilation with clang.
> >>
> >> Please elaborate.  It builds just fine with clang here.  Is it pickier
> >> on Darwin or something?
> >
> > No, I hit it while compiling MPlayer, looks like normal FFmpeg build
> doesn't
> > hit that part of the code.
>
> That code is definitely compiled in FFmpeg (I verified as much just now).
> There must be something else going on.



This is what I see in MPlayer;

clang -I.. -I../../  -DHAVE_AV_CONFIG_H -D_ISOC99_SOURCE -D_BSD_SOURCE -O2
-march=core2 -pipe -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE64_SOURCE -Ilibdvdread4 -mdynamic-no-pic -I. -Iffmpeg  -DPIC
 -I/usr/X11/include -I/usr/X11/include/freetype2 -I/usr/X11/include
-DFF_API_MAX_STREAMS=0   -MD -MP -D_ISOC99_SOURCE -D_BSD_SOURCE -O2
-march=core2 -pipe -c -o x86/snowdsp_mmx.o x86/snowdsp_mmx.c
x86/snowdsp_mmx.c:757:50: error: ambiguous instructions require an explicit
suffix (could be 'addb', 'addw', 'addl', or
      'addq')
             "movdqu %%xmm1, (%%"REG_d")       \n\t"
                                                 ^
<inline asm>:73:2: note: instantiated into assembly here
        add $8*1, -40(%rbp)
        ^
x86/snowdsp_mmx.c:735:18: error: ambiguous instructions require an explicit
suffix (could be 'addb', 'addw', 'addl', or
      'addq')
snow_inner_add_yblock_sse2_end_8
^
x86/snowdsp_mmx.c:677:48: note: instantiated from:
             "sal $1, %%"REG_c"              \n\t"\
                                               ^
<inline asm>:95:2: note: instantiated into assembly here
        add $8*2, -40(%rbp)
        ^
2 errors generated.
make[1]: *** [x86/snowdsp_mmx.o] Error 1
make: *** [ffmpeg/libavcodec/libavcodec.a] Error 2