[FFmpeg-devel] [RFC][PATCH] Windows Television (WTV) file system handling

[Peter Ross]

On Sun, Jan 23, 2011 at 07:49:31AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Jan 22, 2011 at 8:43 PM, Peter Ross <pross at xvid.org> wrote:
> > On Sat, Jan 22, 2011 at 11:37:28AM -0500, Ronald S. Bultje wrote:
> >> On Sat, Jan 22, 2011 at 5:20 AM, Peter Ross <pross at xvid.org> wrote:
> >> > On Thu, Jan 20, 2011 at 06:39:11PM -0500, Ronald S. Bultje wrote:
> >> >> On Thu, Jan 20, 2011 at 6:31 PM, Peter Ross <pross at xvid.org> wrote:
> >> >> > On Thu, Jan 20, 2011 at 09:03:57AM -0500, Ronald S. Bultje wrote:
> >> >> >> On Thu, Jan 20, 2011 at 12:19 AM, Peter Ross <pross at xvid.org> wrote:
> >> >> >> > On Sun, Jan 09, 2011 at 05:21:20PM +1100, Peter Ross wrote:
> >> >> >> >> 0002-add-AVFMT_NOGENERICSEEK-flag.patch
> >> >> >> >> * adds AVFMT_NOGENERICSEEK flag, which should be self explanatory.
> >> >> >> [..]

> >> L is a wchar string, so what I want you to do is to convert it to a
> >> UTF16 string or whatever it is in wtv.c. Ugly way:
> >> "t\0i\0m\0e\0l\0i\0n\0e\0";, but there's probably less ugly ways or
> >> macros that you can use in some of libc. You can also use (uint16_t
> >> str[]){'t','i','m','e','l','i','n','e','\0'} although that has
> >> endianness issues so you need to probably make a macro
> >> UTF16LE_STR("bla") which does the magic for you in whatever way. I'm
> >> not very good at macros with loops inside them, but in the end what I
> >> want is a compare without a convert. In the worst case, like I said,
> >> just have some static uint8_t timeline_u16le[] = 't',0,'i',0,[etc.] in
> >> the file to help you get this done.
> >
> > This looks good. Patch updated.
> >
> > Have also fixed get_utf16lez to convert utf-16 -> utf-8.
> 
> I was worried for a second we were in twilight, but this looks much
> better now. Also nice macro for the le16 strings. Can you point to a
> file on incoming so we can add one to fate after this is committed?

Ronald, No worries. I have updated the patch to use avio_get_str16le().
A reference file can be found in MPlayer/incoming/fate-wtv. Cheers,

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wtv-filesystem-implementation.patch
Type: text/x-diff
Size: 26800 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110126/00a2151f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110126/00a2151f/attachment.pgp>