[FFmpeg-devel] [PATCH 10/11] Mark C base versions of FFT functions static to fft.c

Alex Converse alex.converse
Wed Jan 26 07:16:47 CET 2011


On Tue, Jan 25, 2011 at 6:17 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Jan 25, 2011 at 02:29:43AM +0100, Diego Elio Petten? wrote:
>> ---
>> ?libavcodec/fft.c | ? ?7 +++++--
>> ?libavcodec/fft.h | ? ?2 --
>> ?2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> --- a/libavcodec/fft.c
>> +++ b/libavcodec/fft.c
>> @@ -53,6 +53,9 @@ COSTABLE_CONST FFTSample * const ff_cos_tabs[] = {
>>
>> +static void ff_fft_permute_c(FFTContext *s, FFTComplex *z);
>> +static void ff_fft_calc_c(FFTContext *s, FFTComplex *z);
>
> I would slightly prefer this without the forward declaration and the
> ff_ prefixes.
>

meh,

All the optimized versions have to keep the prefix, this makes things
more consistent.

Regards,
Alex Converse



More information about the ffmpeg-devel mailing list