[FFmpeg-devel] [FFmpeg-commits] mov: simplify mov_read_chapters() by using avio_get_str16be

John Stebbins stebbins
Wed Jan 26 07:15:49 CET 2011


On 01/25/2011 02:37 PM, John Stebbins wrote:
> On 01/25/2011 12:47 PM, Anton Khirnov wrote:
>> Module: ffmpeg
>> Branch: master
>> Commit: c34461b35b68ff1f3d04540e0279383c51be8cee
>>
>> Author: Anton Khirnov<anton at khirnov.net>
>> Date:   Sun Jan 23 12:38:30 2011 +0100
>>
>> mov: simplify mov_read_chapters() by using avio_get_str16be
>>
>> It probably also fixes a memleak or two.
>>
>> Signed-off-by: Janne Grunau<janne-ffmpeg at jannau.net>
>>
>>
> I don't suppose you would be willing to make this work with little-endian utf16 chapter names as well. I've seen an
> mp4with such names that this (and the previous implementation) would choke on. I can supply the sample if needed.

Here's a patch to that works for us. It's pretty straight forward.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov-chap-utf16le.diff
Type: text/x-patch
Size: 588 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110125/264b66bd/attachment.bin>



More information about the ffmpeg-devel mailing list