[FFmpeg-devel] Fwd: [issue2563] AVI encoder create a file (contains multiple video and audio streams) with uncorrect fourcc tag

[Michael Niedermayer]

On Mon, Jan 24, 2011 at 09:12:58PM -0500, Ronald S. Bultje wrote:
> Hi guys,
> 
> posting next patch:
> 
> longstone <zhibing.min at hotmail.com> added the comment:
> > Add error check in avi_write_header() function.
> 
> Looks fine to me, although I guess 99 should be 100 (100 streams means
> IDs 00-99).
> 
> Ronald

>  avi.h    |    1 +
>  avienc.c |   10 ++++++++--
>  2 files changed, 9 insertions(+), 2 deletions(-)
> b21af502b7b85ec94eecd39021ce08aee4b06e3f  _Issue_2563__Resolution.patch
> Index: libavformat/avi.h
> ===================================================================
> --- libavformat/avi.h	(revision 26402)
> +++ libavformat/avi.h	(working copy)
> @@ -32,6 +32,7 @@
>  
>  #define AVI_MAX_RIFF_SIZE       0x40000000LL
>  #define AVI_MASTER_INDEX_SIZE   256
> +#define AVI_MAX_STREAM_COUNT  99		//AVI format is able to assign stream ID for at most 99 streams

tabs
also we could export the max stream value in AVOutputFormat, thats not needed
to make me happy about the patch but it seems somehow nicer as it provides more
information for the outside and earlier without added complexity
actually the check could be factored out into common code


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110125/32130b70/attachment.pgp>