[FFmpeg-devel] [PATCH 09/11] Make ff_h264_decode_rbsp_trailing static to h264.c

[Michael Niedermayer]

On Tue, Jan 25, 2011 at 02:16:59PM +0000, M?ns Rullg?rd wrote:
> Diego Elio Petten? <flameeyes at gmail.com> writes:
> 
> > Il giorno mar, 25/01/2011 alle 06.38 -0500, Ronald S. Bultje ha scritto:
> >> Oh yes I missed that one, please use ff_ on anything you make static. 
> >
> > I actually kept ff_ intentionally so that if the symbol is needed to be
> > exported later on it doesn't need to be renamed again. But okay I'll
> > re-work those on to drop ff_ if that's preferred.
> 
> The ff_ doesn't do any harm, but it does make the patch smaller and
> easier to review.

i agree

leaving it also decreases the chances of breaking local changes as well as
decreasing the work to add the function back into the API

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110125/4776bddd/attachment.pgp>