[FFmpeg-devel] [PATCH 2/9] Make ff_sin_tabs constant to rdft.c

[Reimar Döffinger]

On Mon, Jan 24, 2011 at 09:44:19PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Jan 24, 2011 at 8:59 PM, Diego Elio Petten? <flameeyes at gmail.com> wrote:
> > ---
> > ?libavcodec/rdft.c | ? ?2 +-
> > ?1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/libavcodec/rdft.c b/libavcodec/rdft.c
> > index f37263b..59b4624 100644
> > --- a/libavcodec/rdft.c
> > +++ b/libavcodec/rdft.c
> > @@ -44,7 +44,7 @@ SINTABLE(16384);
> > ?SINTABLE(32768);
> > ?SINTABLE(65536);
> > ?#endif
> > -SINTABLE_CONST FFTSample * const ff_sin_tabs[] = {
> > +static SINTABLE_CONST FFTSample * const ff_sin_tabs[] = {
> > ? ? NULL, NULL, NULL, NULL,
> > ? ? ff_sin_16, ff_sin_32, ff_sin_64, ff_sin_128, ff_sin_256, ff_sin_512, ff_sin_1024,
> > ? ? ff_sin_2048, ff_sin_4096, ff_sin_8192, ff_sin_16384, ff_sin_32768, ff_sin_65536,
> > --
> > 1.7.4.rc2
> 
> Please drop ff_ prefix if making non-static.

I don't mind much, but
1) it's a bit more changes
2) it is a bit strange to have ff_cos_tabs but sin_tabs