[FFmpeg-devel] [PATCH 03/11] Mark metadata conversion table for ID3v2.2 as static to id3v2.c.

[Diego Biurrun]

On Tue, Jan 25, 2011 at 12:36:11AM +0100, Diego Elio Petten? wrote:
> This table is never used outside of ff_id3v2_read, so it makes sense to be
> staticised.
> ---
> --- a/libavformat/id3v2.c
> +++ b/libavformat/id3v2.c
> @@ -248,6 +248,8 @@ static void ff_id3v2_parse(AVFormatContext *s, int len, uint8_t version, uint8_t
>  
> +static const AVMetadataConv ff_id3v2_2_metadata_conv[];
> +
>  void ff_id3v2_read(AVFormatContext *s, const char *magic)
>  {

The forward declaration is ugly so I'd slightly prefer for the table to
get moved if that's easily possible.

Diego