[FFmpeg-devel] [PATCH] Fix ADPCM MS in mov muxing

[Ronald S. Bultje]

Hi,

2011/1/22 M?ns Rullg?rd <mans at mansr.com>:
> Alex Converse <alex.converse at gmail.com> writes:
>> 2011/1/22 M?ns Rullg?rd <mans at mansr.com>:
>>> Alex Converse <alex.converse at gmail.com> writes:
>>>> @@ -2108,6 +2118,7 @@ static int mov_write_header(AVFormatContext *s)
>>>> ? ? ? ? ? ? ?if(!st->codec->frame_size && !av_get_bits_per_sample(st->codec->codec_id)) {
>>>> ? ? ? ? ? ? ? ? ?av_log(s, AV_LOG_ERROR, "track %d: codec frame size is not set\n", i);
>>>> ? ? ? ? ? ? ? ? ?goto error;
>>>> + ? ? ? ? ? ?}else if(st->codec->codec_id == CODEC_ID_ADPCM_MS) {
>>>> ? ? ? ? ? ? ?}else if(st->codec->frame_size > 1){ /* assume compressed audio */
>>>> ? ? ? ? ? ? ? ? ?track->audio_vbr = 1;
>>>> ? ? ? ? ? ? ?}else{
>>>
>>> This looks a bit odd.
>>
>> It means it's not either of the cases below. If it turns out that
>> other ACM codecs need to be muxed like MS ADPCM we could set a flag
>> there.
>
> Makes sense.

Please add a comment to make it clear this is not a bug. :-).

Ronald