[FFmpeg-devel] [PATCH] Remove printf format string errors in windows builds

[JonY]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 1/24/2011 10:50, Larry Robinson wrote:
> On 1/23/2011 6:06 PM, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Sun, Jan 23, 2011 at 9:03 PM, JonY<jon_y at users.sourceforge.net> 
>> wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> On 1/24/2011 09:55, Ronald S. Bultje wrote:
>>>> Hi,
>>>>
>>>> On Sun, Jan 23, 2011 at 8:21 PM, Larry
>>>> Robinson<silver-dad at comcast.net>  wrote:
>>>>> Jean-Baptiste Kempf for pointing this out), but this is not yet
>>>>> implemented
>>>>> for sscanf in Mingw-w64.
>>>>>
>>>>> What breaks is a number of error messages which will print
>>>>> incorrectly, but
>>>>> for a successful run these sections of code are not executed.
>>>> bash-3.2$ grep -r sscanf .. 2>&1 | grep -v matches | grep %z
>>>> bash-3.2$ grep -r sscanf .. 2>&1 | grep -v matches | grep %t
>>>> bash-3.2$
>>>>
>>>> I don't see a problem.
>>>>
>>> Hi,
>>>
>>> So, ffmpeg doesn't use any scanf format that msvcrt doesn't understand?
>> I indeed think ffmpeg does not use such scanf formats. We only use
>> %z/%t/etc for printf(), av_log() etc.
>>
>> Ronald
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at mplayerhq.hu
>> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>>
> A few lines from my build on x86_64-w64-mingw32:
> 
> CC    libavcodec/h264.o
> /home/Larry/Projects/ffmpeg/ffmpeg/libavcodec/h264.c:1:0: warning: -fPIC
> ignored for target (all code is position independent)
> [...]
> /home/Larry/Projects/ffmpeg/ffmpeg/libavcodec/h264.c: In function
> 'decode_slice':
> /home/Larry/Projects/ffmpeg/ffmpeg/libavcodec/h264.c:2539:17: warning:
> unknown conversion type character 't' in format
> /home/Larry/Projects/ffmpeg/ffmpeg/libavcodec/h264.c:2539:17: warning:
> too many arguments for format
> [...]
> 
> line 2539 in h264.c is:
> av_log(h->s.avctx, AV_LOG_ERROR, "error while decoding MB %d %d,
> bytestream (%td)\n", s->mb_x, s->mb_y, h->cabac.bytestream_end -
> h->cabac.bytestream);
> 
> so it is indeed av_log that is generating the warnings.
> 
> Anyway I think M?ns Rullg?rd's suggestion to wait at least until we know
> what plans there are for implementing the proper functions in mingw-w64
> is probably best.
> 
> Regards,
> Larry Robinson
> 

Hi,

implementing scanf fixups would be a far off goal unless somebody
volunteers to donate some code. There have been plans, but nothing solid
yet as stated in
<http://sourceforge.net/apps/trac/mingw-w64/wiki/printf%20and%20scanf%20family>.

I just checked libmingwex.a in mingw32, mingw32 seems to be in the same
position as mingw-w64, it too doesn't have scanf fixups either.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (MingW32)

iEYEARECAAYFAk089MIACgkQp56AKe10wHfTVgCdEDhHyntbCH99l32k4ToAMY1h
3hoAn3bglV7Jc42MG5TXnu7G0XES2Hth
=cmEx
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0xED74C077.asc
Type: application/pgp-keys
Size: 1685 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110124/dfe6dfb5/attachment.key>