[FFmpeg-devel] [PATCH]wmv3 encoder

[Diego Biurrun]

On Sun, Jan 23, 2011 at 05:57:43PM +0100, Vitor Sessak wrote:
>
> Git-friendly patch attached so patchwork will catch it up.

missing changelog update, docs entry

> --- /dev/null
> +++ b/libavcodec/vc1enc.c
> @@ -0,0 +1,397 @@
> +
> +/* msmpeg4 externs*/
> +extern void ff_msmpeg4_encode_block(MpegEncContext * s, DCTELEM * block, int n);
> +extern void ff_find_best_tables(MpegEncContext * s);
> +extern void ff_code012(PutBitContext *pb, int n);

Ugly, this should be a header.

> +AVCodec wmv3_encoder = {
> +        "wmv3",
> +        CODEC_TYPE_VIDEO,
> +        CODEC_ID_WMV3,
> +        sizeof(VC1Context),

long_name is missing.

> --- /dev/null
> +++ b/libavcodec/vc1enc.h
> @@ -0,0 +1,30 @@
> +/*
> + * VC-1 and WMV3 encoder
> + * copyright (c) 2007 Denis Fortin
> + *
> + * This file is part of FFmpeg.
> + *
> + * FFmpeg is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * FFmpeg is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> + */
> +#ifndef VC1ENC_H
> +#define VC1ENC_H
> +
> +#endif /* VC1ENC_H */

Not our standard multiple inclusion guards.

Diego