[FFmpeg-devel] [PATCH] ffserver: put gcc attribute under proper ifdef

Måns Rullgård mans
Sun Jan 23 19:49:32 CET 2011


Diego Biurrun <diego at biurrun.de> writes:

> On Sun, Jan 23, 2011 at 06:31:31PM +0000, Mans Rullgard wrote:
>> ---
>>  ffserver.c |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>> 
>> --- a/ffserver.c
>> +++ b/ffserver.c
>> @@ -384,7 +384,10 @@ static void http_vlog(const char *fmt, va_list vargs)
>>  
>> -static void __attribute__ ((format (printf, 1, 2))) http_log(const char *fmt, ...)
>> +#ifdef __GNUC__
>> +__attribute__ ((format (printf, 1, 2)))
>> +#endif
>> +static void http_log(const char *fmt, ...)
>
> Is there no way to avoid this non-portable attribute?  Otherwise OK.

Removing it entirely is of course an option, but then we'd lose the
format/argument checking enabled by it.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list