[FFmpeg-devel] [PATCH] Add FATE test for rare overflow-prone case

[Måns Rullgård]

Vitor Sessak <vitor1001 at gmail.com> writes:

> $subj, see issue 2547.
>
> -Vitor
>
> PS: no need to wait boxes to rsync, this sample was uploaded several
> days ago.
>
> From 7d36f70ea1693233085939c66491354cd82fad9a Mon Sep 17 00:00:00 2001
> From: Vitor Sessak <vitor1001 at gmail.com>
> Date: Sun, 23 Jan 2011 18:58:34 +0100
> Subject: [PATCH] Add FATE test for rare overflow-prone case
>
> ---
>  tests/fate/h264.mak                |    2 ++
>  tests/ref/fate/h264-might-overflow |   29 +++++++++++++++++++++++++++++
>  2 files changed, 31 insertions(+), 0 deletions(-)
>  create mode 100644 tests/ref/fate/h264-might-overflow
>
> diff --git a/tests/fate/h264.mak b/tests/fate/h264.mak
> index 25517fe..5d6fa43 100644
> --- a/tests/fate/h264.mak
> +++ b/tests/fate/h264.mak
> @@ -167,6 +167,7 @@ FATE_H264 = aud_mw_e                                                    \
>  FATE_H264  := $(FATE_H264:%=fate-h264-conformance-%)                    \
>                fate-h264-interlace-crop                                  \
>                fate-h264-lossless                                        \
> +              fate-h264-might-overflow                                  \
>  
>  FATE_TESTS += $(FATE_H264)
>  fate-h264: $(FATE_H264)
> @@ -339,3 +340,4 @@ fate-h264-conformance-sva_nl2_e: CMD = framecrc  -i $(SAMPLES)/h264-conformance/
>  
>  fate-h264-interlace-crop: CMD = framecrc  -vframes 3 -i $(SAMPLES)/h264/interlaced_crop.mp4
>  fate-h264-lossless: CMD = framecrc -i $(SAMPLES)/h264/lossless.h264
> +fate-h264-might-overflow: CMD = framecrc -i $(SAMPLES)/h264/H264_might_overflow.mkv

I'd prefer a slightly more descriptive name for this test.  What
does it actually test?  "Might overflow" is a lie too, since a correct
decoder does not overflow.

-- 
M?ns Rullg?rd
mans at mansr.com