[FFmpeg-devel] [PATCH] DCA-in-WAV detection

[Ronald S. Bultje]

Hi,

On Sun, Jan 23, 2011 at 11:46 AM, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On 05/11/2007 05:04 AM, Kostya wrote:
>>
>> On Fri, May 04, 2007 at 09:40:01AM +0300, Kostya wrote:
>>>
>>> Here is my attempt on patch discussed on Febryary 2006
>>> Thread called "[PATCH] Fix DTS in WAV file playback."
>>
>> ping
>
> Git-friendly patch attached. Hope that patchwork will catch it up.
[..]
> @@ -186,6 +238,10 @@ static int wav_read_header(AVFormatContext *s,
>      size = find_tag(pb, MKTAG('d', 'a', 't', 'a'));
>      if (size < 0)
>          return -1;
> +
> +    /* check if it's really PCM or hidden DTS */
> +    if (codec_get_id (codec_wav_tags, st->codec->codec_tag) == CODEC_ID_PCM_S16LE)
> +        find_dts_header (pb, st->codec);
>      wav->data_end= url_ftell(pb) + size;
>      return 0;
>  }

if (st->codec->codec_tag == 1) is fine here, no reason to run through
that table twice. The detection itself looks good to me but is against
an old git revision so probably needs to be hand-merged...

Ronald