[FFmpeg-devel] [PATCH 2/4] aacenc: add recognized profiles array

[Anssi Hannula]

On 22.01.2011 00:49, Nathan Caldwell wrote:
> On Fri, Jan 21, 2011 at 1:49 PM, Anssi Hannula <anssi.hannula at iki.fi> wrote:
>> On 21.01.2011 22:31, Nathan Caldwell wrote:
>>> On Fri, Jan 21, 2011 at 12:21 PM, Anssi Hannula <anssi.hannula at iki.fi> wrote:
>>>> ---
>>>>  libavcodec/aacenc.c |    6 ++++++
>>>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
>>>> index c52ffa0..762e0c8 100644
>>>> --- a/libavcodec/aacenc.c
>>>> +++ b/libavcodec/aacenc.c
>>>> @@ -636,6 +636,11 @@ static av_cold int aac_encode_end(AVCodecContext *avctx)
>>>>     return 0;
>>>>  }
>>>>
>>>> +static const AVProfile profiles[] = {
>>>> +    { FF_PROFILE_AAC_LOW,  "Low"  },
>>>
>>> Couple of nits: I would prefer FF_PROFILE_AAC_LC here.
>>
>> Well, FF_PROFILE_AAC_LOW already exists, but of course "Low" can be
>> changed to "LC".
> 
> That's fine then. I had about 2 seconds before I needed to leave to
> work, and didn't get a chance to look over any more than this patch.
> 
>>> Also, is there
>>> a limit to the string length? "Low Complexity" would probably be
>>> better descriptive name.
>>
>> Well, I'd favor a shorter string as this is shown in e.g. avcodec_string().
> 
> What about "LC" then?

Would be my first choice as well, I only used "Low" due to the existing
#define. I'll change it for the resent patchset :)

-- 
Anssi Hannula