[FFmpeg-devel] [PATCH 4/4] dca: add profile names

[Benjamin Larsson]

On 01/21/2011 08:47 PM, Anssi Hannula wrote:
> On 21.01.2011 21:40, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Fri, Jan 21, 2011 at 2:21 PM, Anssi Hannula <anssi.hannula at iki.fi> wrote:
>>> ---
>>>  libavcodec/dca.c |   10 ++++++++++
>>>  1 files changed, 10 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/libavcodec/dca.c b/libavcodec/dca.c
>>> index bc099e1..48b79e8 100644
>>> --- a/libavcodec/dca.c
>>> +++ b/libavcodec/dca.c
>>> @@ -1869,6 +1869,15 @@ static av_cold int dca_decode_end(AVCodecContext * avctx)
>>>     return 0;
>>>  }
>>>
>>> +static const AVProfile profiles[] = {
>>> +    { FF_PROFILE_DTS,        "DTS"        },
>>> +    { FF_PROFILE_DTS_ES,     "DTS-ES"     },
>>> +    { FF_PROFILE_DTS_96_24,  "DTS 96/24"  },
>>> +    { FF_PROFILE_DTS_HD_HRA, "DTS-HD HRA" },
>>> +    { FF_PROFILE_DTS_HD_MA,  "DTS-HD MA"  },
>>> +    { FF_PROFILE_UNKNOWN },
>>> +};
>>> +
>>>  AVCodec dca_decoder = {
>>>     .name = "dca",
>>>     .type = AVMEDIA_TYPE_AUDIO,
>>> @@ -1879,4 +1888,5 @@ AVCodec dca_decoder = {
>>>     .close = dca_decode_end,
>>>     .long_name = NULL_IF_CONFIG_SMALL("DCA (DTS Coherent Acoustics)"),
>>>     .capabilities = CODEC_CAP_CHANNEL_CONF,
>>> +    .profiles = profiles,
>>>  };
>>> --
>>> 1.7.3
>>
>> What is the effect of exporting profile names in a decoder? Just to
>> show what we support?
> 
> To allow applications to show a profile name to the user.
> 

Then maybe it should be inside NULL_IF_CONFIG_SMALL().

MvH
Benjamin Larsson