[FFmpeg-devel] [PATCH 2/4] aacenc: add recognized profiles array

[Anssi Hannula]

On 21.01.2011 22:31, Nathan Caldwell wrote:
> On Fri, Jan 21, 2011 at 12:21 PM, Anssi Hannula <anssi.hannula at iki.fi> wrote:
>> ---
>>  libavcodec/aacenc.c |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>
>> diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
>> index c52ffa0..762e0c8 100644
>> --- a/libavcodec/aacenc.c
>> +++ b/libavcodec/aacenc.c
>> @@ -636,6 +636,11 @@ static av_cold int aac_encode_end(AVCodecContext *avctx)
>>     return 0;
>>  }
>>
>> +static const AVProfile profiles[] = {
>> +    { FF_PROFILE_AAC_LOW,  "Low"  },
> 
> Couple of nits: I would prefer FF_PROFILE_AAC_LC here.

Well, FF_PROFILE_AAC_LOW already exists, but of course "Low" can be
changed to "LC".

> Also, is there
> a limit to the string length? "Low Complexity" would probably be
> better descriptive name.

Well, I'd favor a shorter string as this is shown in e.g. avcodec_string().

It is already quite long in case of channel layouts, though, but I don't
know if it is still a good idea to make it even longer. Example:
Stream #0.0: Audio: dca (DTS-HD MA), 48000 Hz, 7 channels
(FL|FR|FC|LFE|BC|SL|SR), s16, 1536 kb/s

But I don't care much about this, i.e. I'm fine with a longer string if
others are (however, in such a case we might want to use more
descriptive strings for other profiles as well, for consistency).

-- 
Anssi Hannula