[FFmpeg-devel] [PATCH 2/6] id3v2: use an enum for encodings instead of magic numbers.

Diego Biurrun diego
Fri Jan 21 16:14:35 CET 2011


On Fri, Jan 21, 2011 at 03:22:12PM +0100, Anton Khirnov wrote:
> 
> --- a/libavformat/id3v2.h
> +++ b/libavformat/id3v2.h
> @@ -38,6 +38,13 @@
>  
> +enum ID3v2Encoding {
> +    ID3v2_ENCODING_ISO8859,
> +    ID3v2_ENCODING_UTF16BOM,
> +    ID3v2_ENCODING_UTF16BE,
> +    ID3v2_ENCODING_UTF8,

Are these taken from a standard document or just local definitions?
In the former case a reference would be good.

Looks good otherwise.

Diego



More information about the ffmpeg-devel mailing list