[FFmpeg-devel] [PATCH 2/2] Makefile: simplify test tools handling

Diego Biurrun diego
Fri Jan 21 16:05:06 CET 2011


On Thu, Jan 20, 2011 at 10:55:02PM +0000, Mans Rullgard wrote:
> Signed-off-by: Mans Rullgard <mans at mansr.com>
> ---
>  Makefile |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 98ec5f5..a1fd7b4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -16,7 +16,8 @@ MANPAGES    = $(PROGS-yes:%=doc/%.1)
>  TOOLS       = $(addprefix tools/, $(addsuffix $(EXESUF), cws2fws pktdumper probetest qt-faststart trasher))
> -HOSTPROGS   = $(addprefix tests/, audiogen videogen rotozoom tiny_psnr base64)
> +TESTPROGS   = audiogen videogen rotozoom tiny_psnr base64
> +HOSTPROGS  := $(TESTPROGS:%=tests/%)

nit: maybe alphabetical order

> @@ -162,7 +163,7 @@ testclean:
>  	$(RM) tests/seek_test$(EXESUF) tests/seek_test.o
> -	$(RM) $(addprefix tests/,$(addsuffix $(HOSTEXESUF),audiogen videogen rotozoom tiny_psnr base64))
> +	$(RM) $(TESTPROGS:%=tests/%$(HOSTEXESUF))

Why not use HOSTPROGS here?  The variable is currently unused...

Diego



More information about the ffmpeg-devel mailing list