[FFmpeg-devel] [PATCH 1/3] Move lpc_compute_autocorr() from DSPContext to a new struct LPCContext.

[Michael Niedermayer]

On Fri, Jan 21, 2011 at 12:59:06AM +0000, M?ns Rullg?rd wrote:
> Justin Ruggles <justin.ruggles at gmail.com> writes:
> 
> > ---
> >  libavcodec/alacenc.c            |   14 +++++++-------
> >  libavcodec/dsputil.c            |    4 ----
> >  libavcodec/dsputil.h            |    2 --
> >  libavcodec/flacenc.c            |    7 +++----
> >  libavcodec/lpc.c                |   13 ++++++++++---
> >  libavcodec/lpc.h                |   24 +++++++++++++++++++++---
> >  libavcodec/ra144.h              |    4 ++--
> >  libavcodec/ra144enc.c           |    5 ++---
> >  libavcodec/x86/dsputil_mmx.h    |    3 ---
> >  libavcodec/x86/dsputilenc_mmx.c |    4 ----
> >  libavcodec/x86/lpc_mmx.c        |   14 ++++++++++++--
> >  11 files changed, 57 insertions(+), 37 deletions(-)
> 
> All three patches look good.  However, some struct offsets used in ARM
> asm need updating.  I'll figure out the new values and apply tomorrow.

Dont you think that the code that contains these offsets would benefit more from
cleanup to not break when random structs change than regularly waiting for
failure and then find someone with an ARM build env to fix?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There seems to be only one solution to NIH syndrom, ... a shooting squad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110121/c4be1dbf/attachment.pgp>