[FFmpeg-devel] PATCH: mpegtsenc.c

[Måns Rullgård]

Tomas H?rdin <tomas.hardin at codemill.se> writes:

> M?ns Rullg?rd skrev 2011-01-19 22:29:
>> Tomas H?rdin<tomas.hardin at codemill.se>  writes:
>>
>>> Georgi Chorbadzhiyski skrev 2011-01-19 08:20:
>>>> Around 01/19/11 04:02, M?ns Rullg?rd scribbled:
>>>>> JULIAN GARDNER<joolzg at btinternet.com>   writes:
>>>>>
>>>>>> Hi new user here.
>>>>>>
>>>>>> I have the following patch which allows the user through the
>>>>>> --metadata to also change the provider name on TS files, a bit like
>>>>>> the title option changes the service name.
>>>>
>>>> Two old patches of mine that allow
>>>>
>>>> ffmpeg -metadata provider_name="Some provider name" -metadata service_name="Some TV channel"
>>>>
>>>> to work for mpeg ts files/streams.
>>>
>>> Seems like a decent solution, however: shouldn't AVOption be used for
>>> this?
>>
>> This feels very much like metadata to me.
>
> Hm. I think you're right.
> The metadata key for the muxer and demuxer is different for the
> service name though - the demuxer calls it "name" while this patch
> would use "service_name" for the muxer. Perhaps the former should be
> fixed up after this patch is applied?

Keeping it consistent is certainly a good idea.  As service_name is
more accurate, fixing the demuxer is the way to go.  Patches welcome.

-- 
M?ns Rullg?rd
mans at mansr.com