[FFmpeg-devel] [PATCH 4/7] Untemplatize C code part 1

[Ronald S. Bultje]

Hi,

On Wed, Jan 19, 2011 at 6:46 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
> @@ -81,14 +81,13 @@ DECLARE_ASM_CONST(8, uint64_t, blue_15mask) ?= 0x0000001f0000001fULL;
>
> ?//Note: We have C, MMX, MMX2, 3DNOW versions, there is no 3DNOW + MMX2 one.
> ?//plain C versions
> +#include "rgb2rgb_template.c"
> +
> +#if ARCH_X86
> ?#define COMPILE_TEMPLATE_MMX 0
> ?#define COMPILE_TEMPLATE_MMX2 0
> ?#define COMPILE_TEMPLATE_AMD3DNOW 0
> ?#define COMPILE_TEMPLATE_SSE2 0
> -#define RENAME(a) a ## _C
> -#include "rgb2rgb_template.c"
> -
> -#if ARCH_X86
>
> ?//MMX versions
> ?#undef RENAME

I think all those lines should go away, right? Or are they reused for
the lines below (didn't check)? Also, I suppose rgb2rgb_template.c
could now be renamed to something more sensible, like rgb2rgb.c,
whereas rgb2rgb.c is now rgb2rgb_init.c?

Ronald