[FFmpeg-devel] [PATCH 1/7] Thin rgb2rgb a little part 1 of many

[Ronald S. Bultje]

Hi,

2011/1/19 M?ns Rullg?rd <mans at mansr.com>:
> Diego Biurrun <diego at biurrun.de> writes:
>
>> On Thu, Jan 20, 2011 at 12:46:20AM +0100, Luca Barbato wrote:
>>> Move the function pointers in a separate file.
>>> It will removed once the pointers will be factored in a more structured
>>> form
>>>
>>> --- /dev/null
>>> +++ b/libswscale/swscale_functions.c
>>> @@ -0,0 +1,67 @@
>>> +#include <inttypes.h>
>>
>> stdint.h is enough and please add the standard license header.
>>
>>> +void (*yv12toyuy2)(const uint8_t *ysrc, const uint8_t *usrc, const uint8_t *vsrc, uint8_t *dst,
>>> + ? ? ? ? ? ? ? ? ? long width, long height,
>>> + ? ? ? ? ? ? ? ? ? long lumStride, long chromStride, long dstStride);
>>
>> Shorten lines while you're at it?
>
> I got the impression this file was going away entirely before it's
> done. ?No need to spend time on cosmetics in that case.

I agree for this particular case. If this is going away, I think this is fine.

Ronald