[FFmpeg-devel] [PATCH 5/7] Switch x86_reg to int for the C code

[Ronald S. Bultje]

Hi,

On Wed, Jan 19, 2011 at 6:10 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
> On 01/19/2011 02:03 AM, M?ns Rullg?rd wrote:
>> Luca Barbato <lu_zero at gentoo.org> writes:
>>
>>> ---
>>> ?libswscale/rgb2rgb_template.c | ? 28 ++++++++++++++--------------
>>> ?1 files changed, 14 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/libswscale/rgb2rgb_template.c b/libswscale/rgb2rgb_template.c
>>> index d3d541f..9c0cf8d 100644
>>> --- a/libswscale/rgb2rgb_template.c
>>> +++ b/libswscale/rgb2rgb_template.c
>>> @@ -345,7 +345,7 @@ static inline void rgb16to32_c(const uint8_t *src, uint8_t *dst, long src_size)
>>>
>>> ?static inline void shuffle_bytes_2103_c(const uint8_t *src, uint8_t *dst, long src_size)
>>> ?{
>>> - ? ?x86_reg idx = 15 - src_size;
>>> + ? ?int idx = 15 - src_size;
>>
>> Does this allow you to include x86_cpu.h only from x86/* files too?
>> It is currently included unconditionally in rgb2rgb.c.
>
> On the next commit it does, before we are still including
> x86/rgb2rgb_template.c from the main file.

If this helps in getting rid of that include, then it's OK with me.
Mans, OK also?

Ronald