[FFmpeg-devel] [PATCH 05/17] Use -Bsymbolic for shared libs only, not executables

[Víctor Paesa]

Hi,

2011/1/18 M?ns Rullg?rd:
> Janne Grunau writes:
>
>> On Tue, Jan 18, 2011 at 07:32:09PM +0000, Mans Rullgard wrote:
>>> Some linkers fail if this flag is used when creating an executable file.
>>> Since the flag is meaningful only for shared libraries, dropping it from
>>> the main link flags is correct.
>>> ---
>>> ?configure | ? ?2 +-
>>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 7cd80fd..6100419 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2899,7 +2899,7 @@ enabled extra_warnings && check_cflags -Winline
>>> ?check_ldflags -Wl,--warn-common
>>> ?check_ldflags -Wl,--as-needed
>>> ?check_ldflags '-Wl,-rpath-link,\$(BUILD_ROOT)/libpostproc -Wl,-rpath-link,\$(BUILD_ROOT)/libswscale -Wl,-rpath-link,\$(BUILD_ROOT)/libavfilter -Wl,-rpath-link,\$(BUILD_ROOT)/libavdevice -Wl,-rpath-link,\$(BUILD_ROOT)/libavformat -Wl,-rpath-link,\$(BUILD_ROOT)/libavcodec -Wl,-rpath-link,\$(BUILD_ROOT)/libavcore -Wl,-rpath-link,\$(BUILD_ROOT)/libavutil'
>>> -check_ldflags -Wl,-Bsymbolic
>>> +test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic
>>>
>>> ?echo "X{};" > $TMPV
>>> ?if test_ldflags -Wl,--version-script,$TMPV; then
>>
>> ok
>
> Queued.
>
>> out of curiousity which linker is this?
>
> IRIX IIRC. ?It's not an important platform, but the change is
> logically correct regardless.
>

-Bsymbolic is an ELF flag. most PE linkers warn on that (but don't fail)

Regards,
V?ctor