[FFmpeg-devel] [PATCH] libmpcodecs support

[Baptiste Coudurier]

Hi Michael,

On 01/14/2011 11:57 AM, Michael Niedermayer wrote:
> On Fri, Jan 14, 2011 at 11:45:48AM -0800, Baptiste Coudurier wrote:
>> Hi Michael,
>>
>> On 01/13/2011 08:37 PM, Michael Niedermayer wrote:
>>> Hi
>>>
>>> Attached patchset makes libavfilter support most libmpcodecs filters
>>> The libmpcodecs filters are practically unmodified and for keeping it
>>> maintainable id like to keep them unmodified.
>>>
>>> I will commit this soon but wont enable it yet. That way others can help
>>> cleanup the wraper (minus code that for maintainability should stay identical
>>> to the original), fix bugs, rename all global functions so they wont conflict
>>> with mplayers if they ever include this and generally help.
>>>
>>> Please dont bikeshed this to death.
>>>
>>> Ahh before i can commit this, libmpcodecs and subdirectories must not get
>>> blocked by the tab&   trailing whitespace checkin scripts.
>>>
>>> [...]
>>>
>>>   From fcd1ad739d7c36473813ee0d9c495a57bf2df268 Mon Sep 17 00:00:00 2001
>>> From: Michael Niedermayer<michaelni at gmx.at>
>>> Date: Fri, 14 Jan 2011 05:06:30 +0100
>>> Subject: [PATCH 6/7] Add libmpcodecs wraper for libavfilter, still disabled
>>>
>>> ---
>>>    libavfilter/vf_mp.c |  913 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>>    1 files changed, 913 insertions(+), 0 deletions(-)
>>>    create mode 100644 libavfilter/vf_mp.c
>>>
>>> diff --git a/libavfilter/vf_mp.c b/libavfilter/vf_mp.c
>>
>> The other filters may be kept intact, but the libavfilter wrapper should
>> be reformatted and cleaned up.
>
> Iam undecided about that a bit, i really dont like how it looks either.
> The problem is that the code in the wrapper is to a large extend based and in
> some cases exactly copied from libmpcodecs/vf.c
> so iam not sure what to do. Its easier to maintain if the copied/based code
> stays formated like the original

I see.
I consider this file native libavfilter code and I believe native 
libavfilter code should follow libavfilter coding style and guidelines, 
It could serve as an example for people implementing wrappers as well. 
So IMHO it would be really better if this code was clean and nice.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org