[FFmpeg-devel] [PATCH] Add af_aconvert - sample fmt and channel layout conversion filter

[Stefano Sabatini]

On date Thursday 2011-01-13 03:27:40 +0100, Michael Niedermayer encoded:
> On Wed, Jan 12, 2011 at 10:25:26PM +0100, Stefano Sabatini wrote:
[...]
> > Updated against latest SVN. Consider this a work in progress, many of
> > the fixme need yet to be fixed, Michael please mark what you consider
> > required for the patch to be applied.
> 
> the short types must be fixed IMHO

short -> int16_t
 
> and its (left+right)>>1 not (left>>1)+(right>>1); (trivial)

fixed
 
> The rest from my previous review can wait until after svn
> 
> Theres also another issue that i think must be fixed and that is the naming
> There are 3 things
> 
> 1. Changing the sample rate
> 2. Changing the sample format (int16<->int8<->float)
> 3. Changing the channel layout (stereo<->mono<->5.1)
> 
> 1. is AFIAK called resampling
> 2. is AFIAK called requantization or sample format convertion
> 3. is AFIAK called rematrixing or up/down mixing

I changed the name of the filter resample -> aconvert and the variable
names accordingly.

> If someone has some authorative (_NOT_ wikipedia) source that define these
> terms that cant hurt ...
-- 
FFmpeg = Fast & Fancy Most Ponderous Elfic Game