[FFmpeg-devel] [RFC][PATCH] Windows Television (WTV) file system handling

[Aurelien Jacobs]

On Tue, Jan 11, 2011 at 12:42:37AM +0100, Michael Niedermayer wrote:
> On Mon, Jan 10, 2011 at 10:23:56PM +0100, Aurelien Jacobs wrote:
> > On Mon, Jan 10, 2011 at 08:30:33PM +1100, Peter Ross wrote:
> > > On Sun, Jan 09, 2011 at 11:39:00PM +0100, Aurelien Jacobs wrote:
> > > > On Sun, Jan 09, 2011 at 05:21:20PM +1100, Peter Ross wrote:
> > > > > Hi,
> > > > > 
> > > > > The Windows Television (WTV) file format is a more complex beast than
> > > > > initially imagined.
> > > > > 
> > > > > [...]
> > > > > 
> > > > > * Meta data is parsed. While it is able to extract a thumbnail image, I
> > > > >   have ifdef'd this out, as ffmpeg forbids image attachments using 
> > > > >   AVMEDIA_TYPE_ATTACHMENT.
> > > > 
> > > > I'm not sure what you are talking about here. I don't know what ffmpeg
> > > > forbids, but image attachments seems to work fine with this sample file:
> > > > http://samples.mplayerhq.hu/Matroska/ticket-a_aac.mkv
> > > 
> > > My mistake. It is ffprobe that reports codec id mismatch error, e.g.
> > > 
> > > ---
> > > [matroska,webm @ 0x8be4fd0] max_analyze_duration reached
> > > [matroska,webm @ 0x8be4fd0] Estimating duration from bitrate, this may be inaccurate
> > > Input #0, matroska,webm, from 'ticket-a_aac.mkv':
> > >   Metadata:
> > >     title           : Un ticket pour l'espace
> > >   Duration: 00:00:50.00, start: 0.000000, bitrate: N/A
> > >     Chapter #0.0: start 0.000000, end 50.006000
> > >     Metadata:
> > >       title           : 01. G?n?rique de d?but
> > >     Stream #0.0(fre): Video: h264, yuv420p, 688x288, PAR 36:37 DAR 86:37, 25 fps, 25 tbr, 1k tbn, 50 tbc
> > >     Stream #0.1(fre): Audio: aac, 48000 Hz, 5.1, s16
> > >     Stream #0.2: Attachment: mjpeg
> > >     Metadata:
> > >       filename        : Affiche du film.jpg
> > >     Stream #0.3: Attachment: mjpeg
> > >     Metadata:
> > >       filename        : Cover DVD HD.jpg
> > >     Stream #0.4: Attachment: [0][0][0][0] / 0x0000
> > >     Metadata:
> > >       filename        : tm.ttf
> > > [mjpeg @ 0x8beca20] codec type or id mismatches
> > > Error while opening codec for input stream 2
> > > [mjpeg @ 0x8c1e310] codec type or id mismatches
> > > Error while opening codec for input stream 3
> > 
> > This don't have much to do with the demuxer and is not a good reason to
> > disable the code in the demuxer.
> > It is also quite simple to fix this error with attached patch but I
> > don't know if it is acceptable.
> > 
> > > It doesnt complain for stream #0.4 (ttf), only the jpeg ones.
> > 
> > It also complain for stream #0.4 but for a different (and expected) reason:
> > Unsupported codec (id=98304) for input stream 4
> > 
> > Aurel
> >  utils.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > edf5f5a58155ac8af740cc9416209d95f50170ed  codec_type.diff
> > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> 
> patch looks like a reasonable solution if it works

Applied.

Aurel