[FFmpeg-devel] [PATCH] Move audioconvert API from libavcodec to libavcore.

[Michael Niedermayer]

On Tue, Jan 11, 2011 at 06:25:07PM +0100, Stefano Sabatini wrote:
> On date Tuesday 2011-01-11 15:23:45 +0100, Michael Niedermayer encoded:
> > On Tue, Jan 11, 2011 at 01:10:41PM +0100, Stefano Sabatini wrote:
> > > On date Tuesday 2011-01-11 01:52:46 +0100, Michael Niedermayer encoded:
> > > > On Tue, Jan 11, 2011 at 01:35:45AM +0100, Stefano Sabatini wrote:
> > > > > On date Tuesday 2011-01-11 00:55:46 +0100, Michael Niedermayer encoded:
> > > > > > On Tue, Jan 11, 2011 at 12:20:39AM +0100, Stefano Sabatini wrote:
> > > > > > > On date Sunday 2011-01-09 19:52:26 +0100, Michael Niedermayer encoded:
> > > > > > [...]
> > > > > > > +int av_audio_convert2(AVAudioConvertContext *ctx,
> > > > > > > +                           void * const out[8], const int out_stride[8],
> > > > > > > +                     const void * const  in[8], const int  in_stride[8], int len)
> > > > > > > +{
> > > > > > > +    int ch;
> > > > > > > +
> > > > > > > +    //FIXME optimize common cases
> > > > > > > +
> > > > > > > +    for (ch = 0; ch < ctx->out_channels; ch++) {
> > > > > > > +        const int is =  in_stride[ch];
> > > > > > > +        const int os = out_stride[ch];
> > > > > > > +        const uint8_t *pi=  in[ch];
> > > > > > > +        uint8_t *po  = out[ch];
> > > > > > > +        uint8_t *end = po + os*len;
> > > > > > > +        if (!out[ch])
> > > > > > > +            continue;
> > > > > > 
> > > > > > does git blame pick up this reformated code and associate it correctly to the
> > > > > > original commits ?
> > > > > 
> > > > > No, I'll revert the formatting.
> > > > 
> > > > Thanks alot
> > > 
> > > I'll apply this night if there are no other comments.
> > 
> > Why is this code moved into libavcore and not libavfilter ?
> 
> ???
> 
> Do you want to make libavcodec depend on libavfilter?

id like to avoid having code moved around guided on dependancies that are
going to be removed.

The only reason why audio resampling or similar would be needed in avcodec is
if a decoder or encoder needed it for functioning or optimization.
Thats not impossible but iam not aware of such a case currently.

We have had and exportet the audio resample stuff from avcodec historically
because that happened to have been the best place for it.
I really would like to drop the whole filtering API from libavcodec 
and require users to use libavfilter or a libavaudio like libswscale.


> Also audio
> resampling is not necessarily related to filtering, you may need to
> resample without the need for libavfilter, libavcore seems the right
> place to me.

any single filter can be needed without the others
also one surely can want resampling without anything else of teh core

API design always must be weighting alternatives, it never can be based on a
single argument or use case that would favor one design over the other.
Reason being that you can construct an argument for absolutely anything

With above argument you end up with a single filter per lib, and tomorrow with
a single codec per lib, and the day after with several libs per single codec one
for interlaced material one for progressivem, ... because there always can be
someone who needs just a subset ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110111/396ebe72/attachment.pgp>