[FFmpeg-devel] [PATCH] Move audioconvert API from libavcodec to libavcore.

[Stefano Sabatini]

On date Tuesday 2011-01-11 15:23:45 +0100, Michael Niedermayer encoded:
> On Tue, Jan 11, 2011 at 01:10:41PM +0100, Stefano Sabatini wrote:
> > On date Tuesday 2011-01-11 01:52:46 +0100, Michael Niedermayer encoded:
> > > On Tue, Jan 11, 2011 at 01:35:45AM +0100, Stefano Sabatini wrote:
> > > > On date Tuesday 2011-01-11 00:55:46 +0100, Michael Niedermayer encoded:
> > > > > On Tue, Jan 11, 2011 at 12:20:39AM +0100, Stefano Sabatini wrote:
> > > > > > On date Sunday 2011-01-09 19:52:26 +0100, Michael Niedermayer encoded:
> > > > > [...]
> > > > > > +int av_audio_convert2(AVAudioConvertContext *ctx,
> > > > > > +                           void * const out[8], const int out_stride[8],
> > > > > > +                     const void * const  in[8], const int  in_stride[8], int len)
> > > > > > +{
> > > > > > +    int ch;
> > > > > > +
> > > > > > +    //FIXME optimize common cases
> > > > > > +
> > > > > > +    for (ch = 0; ch < ctx->out_channels; ch++) {
> > > > > > +        const int is =  in_stride[ch];
> > > > > > +        const int os = out_stride[ch];
> > > > > > +        const uint8_t *pi=  in[ch];
> > > > > > +        uint8_t *po  = out[ch];
> > > > > > +        uint8_t *end = po + os*len;
> > > > > > +        if (!out[ch])
> > > > > > +            continue;
> > > > > 
> > > > > does git blame pick up this reformated code and associate it correctly to the
> > > > > original commits ?
> > > > 
> > > > No, I'll revert the formatting.
> > > 
> > > Thanks alot
> > 
> > I'll apply this night if there are no other comments.
> 
> Why is this code moved into libavcore and not libavfilter ?

???

Do you want to make libavcodec depend on libavfilter? Also audio
resampling is not necessarily related to filtering, you may need to
resample without the need for libavfilter, libavcore seems the right
place to me.
-- 
FFmpeg = Fanciful and Fanciful Magnificient Portentous Encoding/decoding Glue