[FFmpeg-devel] [PATCH] better check for truemotion1 vectable IDs (issue2508)

[Michael Niedermayer]

On Sat, Jan 08, 2011 at 01:32:17PM -0500, Daniel Kang wrote:
> ffmpeg checks if the vectable ID is < 4, but not > 0. ffmpeg selects the
> vector table by using "header.vectable - 1" as the index, so for
> header.vectable=0, ffmpeg will crash. The patch attached adds a check
> for negative IDs.

>  truemotion1.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> d1d0df4dcf5b3f06db0fb951ffe426ea563acee1  duk_vectable_id_check.diff
> From 063259b8a15aa7952a3299a339f2052b553093bf Mon Sep 17 00:00:00 2001
> From: Daniel Kang <daniel.d.kang at gmail.com>
> Date: Sat, 8 Jan 2011 00:40:16 -0500
> Subject: [PATCH] truemotion vector ID check

lgtm

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110110/08e81211/attachment.pgp>