[FFmpeg-devel] [PATCH] dca: fix reading over the end of the allocated buffer (v2)

Anssi Hannula anssi.hannula
Sun Jan 9 23:21:52 CET 2011


On 09.01.2011 21:12, Carl Eugen Hoyos wrote:
> Anssi Hannula <anssi.hannula <at> iki.fi> writes:
> 
>> @@ -280,7 +282,7 @@ typedef struct {
>>      DECLARE_ALIGNED(16, float, samples)[(DCA_PRIM_CHANNELS_MAX+1)*256];
>>      const float *samples_chanptr[DCA_PRIM_CHANNELS_MAX+1];
>>
>> -    uint8_t dca_buffer[DCA_MAX_FRAME_SIZE];
>> +    uint8_t dca_buffer[DCA_MAX_FRAME_SIZE + DCA_BUFFER_PADDING_SIZE];
> 
> This hunk doesn't apply and when I tried to fix one of your patches last time,
> it went wrong...

That becomes
DCA_MAX_FRAME_SIZE + DCA_MAX_EXSS_HEADER_SIZE + DCA_BUFFER_PADDING_SIZE.

I did also post the patch against current trunk in my previous reply a
few hours ago, but I guess you didn't notice that :)

-- 
Anssi Hannula



More information about the ffmpeg-devel mailing list