[FFmpeg-devel] [PATCH]Lagarith decoder.

[Nathan Caldwell]

On Sat, Jan 8, 2011 at 7:11 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Jan 05, 2011 at 03:37:29PM -0700, Nathan Caldwell wrote:
>> On Wed, Jan 5, 2011 at 9:15 AM, Reimar D?ffinger
>> <Reimar.Doeffinger at gmx.de> wrote:
>> > On Sun, Dec 13, 2009 at 09:51:10PM +0100, Reimar D?ffinger wrote:
>> >> On Sat, Oct 24, 2009 at 10:54:33PM -0600, Nathan Caldwell wrote:
>> >> > >> + ? ? ? ? ? ?read +=
>> >> > >> + ? ? ? ? ? ? ? ?lag_decode_line(l, &rac, dst + (i * stride), width,
>> >> > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?stride, step, esc_count);
>> >> > >> +
>> >> > >> + ? ? ? ? ? ? ? ?src +=
>> >> > >> + ? ? ? ? ? ? ? ? ? ?lag_decode_zero_run_line(l, dst + (i * stride),
>> >> > >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? src, width, step, esc_count);
>> >> > >
>> >> > > The function calls on the next line look weird.
>> >> >
>> >> > indent's doing. Fixed.
>> >> > Since these are all cosmetic, changes in the next patch.
>> >>
>> >> Any chances you can send a patch with the changes you already did?
>> >
>> > Does anyone have a version of the patch with the changes that were
>> > already done locally?
>> > Or can we get this started again? Despite the horribleness of the
>> > codec a lot of people are interested...
>>
>> Hmm, somehow I missed your reply last year. =(
>
>> Pretty much all my spare free time is taken up by the aac encoder right now.
>
> I suggest we commit this to main svn and continue improvments from there
> that way its easier for other people to help and its harder to become forgotten
> and rot
>
> If people want we could mark it with CODEC_CAP_EXPERIMENTAL or whatever
>

This sounds fine to me.

I was still getting small differences in one of the chroma channels
between the encoder input, and the output of our decoder. They weren't
visible, and didn't seem to cause any prediction errors, so I'm not
sure if this was due to the format (which I suspect), or if there's a
small bug in the decoder somewhere. I never had a chance to check if
the reference decoder did the same thing or not.


-- 
-Nathan Caldwell