[FFmpeg-devel] [PATCH] buffer read sanity check (issue 2503)

Daniel Kang daniel.d.kang
Fri Jan 7 20:27:19 CET 2011


On Fri, Jan 7, 2011 at 10:07 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

>  On Fri, Jan 07, 2011 at 10:02:25AM -0500, Daniel Kang wrote:
> > It would be possible to move the check outside the loop, but I am not
> > sure if target_packet_size*avctx->width*avctx->height would overflow or
> > not. Should I check for this instead?
>
> i think it cant overflow, and i think its source not target
> source is whats added to buf and we check against buf


I have moved the check out of the loops, and have used the correct size.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dpx_buffer_sanity_check.diff
Type: application/octet-stream
Size: 1325 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110107/97f71eef/attachment.obj>



More information about the ffmpeg-devel mailing list