[FFmpeg-devel] [PATCH] fix for roundup issue 2475

[Michael Niedermayer]

On Tue, Jan 04, 2011 at 03:12:41PM -0500, Daniel Kang wrote:
> On Tue, Jan 4, 2011 at 4:02 AM, Reimar D?ffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> 
> >  I think it would still set invalid values if e.g. one is 1 and the other
> > is 0.
> > The condition should possibly be both > 0 or both 0.
> >
> 
> I have updated the patch so that the condition to break (error out)
> is <= 0.

>  utils.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 2827df2facfaf6db66722c4567a6d690f3f041db  wav_assertion_fail_fix.diff
> From 64f351084bf57d4f4612dd1175e64f9f535f77e1 Mon Sep 17 00:00:00 2001
> From: Daniel Kang <daniel.d.kang at gmail.com>
> Date: Sat, 1 Jan 2011 20:08:53 -0500
> Subject: [PATCH] Add sanity check to audio file sample rates.

lgtm if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110105/620c3f0f/attachment.pgp>