[FFmpeg-devel] [PATCH] Make mpeg4 encoder log a more explicit error message when the timebase is not valid.

[Jason Garrett-Glaser]

On Tue, Jan 4, 2011 at 1:16 PM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> ---
> ?libavcodec/mpegvideo_enc.c | ? ?3 ++-
> ?1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
> index 459ede7..81f9acb 100644
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -519,7 +519,8 @@ av_cold int MPV_encode_init(AVCodecContext *avctx)
> ? ? avcodec_get_chroma_sub_sample(avctx->pix_fmt, &chroma_h_shift, &chroma_v_shift);
>
> ? ? if(avctx->codec_id == CODEC_ID_MPEG4 && s->avctx->time_base.den > (1<<16)-1){
> - ? ? ? ?av_log(avctx, AV_LOG_ERROR, "timebase not supported by mpeg 4 standard\n");
> + ? ? ? ?av_log(avctx, AV_LOG_ERROR, "timebase %d/%d not supported by MPEG 4 standard\n",
> + ? ? ? ? ? ? ? s->avctx->time_base.num, s->avctx->time_base.den);
> ? ? ? ? return -1;
> ? ? }
> ? ? s->time_increment_bits = av_log2(s->avctx->time_base.den - 1) + 1;
> --
> 1.7.2.3
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>

Why not add something about what the max timebase is to the error message?

Jason