[FFmpeg-devel] [PATCH 2/3] Add floating-point AC-3 encoder. Rename the fixed-point AC-3 encoder ac3_fixed_encoder. Rename test acodec-ac3 to acodec-ac3_fixed and update dependencies. Modify test lavf-rm to use -acodec ac3_fixed.

Justin Ruggles justin.ruggles
Tue Jan 4 12:55:07 CET 2011


On 01/03/2011 11:59 PM, Michael Niedermayer wrote:

> On Mon, Jan 03, 2011 at 12:04:16PM -0500, Justin Ruggles wrote:
>> On 01/01/2011 03:23 PM, Michael Niedermayer wrote:
>>
>>> On Fri, Dec 31, 2010 at 03:11:39PM -0500, Justin Ruggles wrote:
>>>> ---
>>>>  configure                  |    3 +-
>>>>  libavcodec/Makefile        |    3 +-
>>>>  libavcodec/ac3enc.c        |   11 ++++-
>>>>  libavcodec/ac3enc_fixed.c  |    5 +-
>>>>  libavcodec/ac3enc_float.c  |  115 ++++++++++++++++++++++++++++++++++++++++++++
>>>>  libavcodec/ac3enc_float.h  |   46 +++++++++++++++++
>>>>  libavcodec/allcodecs.c     |    1 +
>>>>  tests/codec-regression.sh  |    4 +-
>>>>  tests/lavf-regression.sh   |    2 +-
>>>>  tests/ref/acodec/ac3       |    2 -
>>>>  tests/ref/acodec/ac3_fixed |    2 +
>>>>  11 files changed, 184 insertions(+), 10 deletions(-)
>>>>  create mode 100644 libavcodec/ac3enc_float.c
>>>>  create mode 100644 libavcodec/ac3enc_float.h
>>>>  delete mode 100644 tests/ref/acodec/ac3
>>>>  create mode 100644 tests/ref/acodec/ac3_fixed
>>>>
>>>
>>>>  configure                  |    3 -
>>>>  libavcodec/Makefile        |    3 -
>>>>  libavcodec/ac3enc.c        |   11 +++-
>>>>  libavcodec/ac3enc_fixed.c  |    5 +
>>>>  libavcodec/ac3enc_float.c  |  115 +++++++++++++++++++++++++++++++++++++++++++++
>>>>  libavcodec/ac3enc_float.h  |   46 ++++++++++++++++++
>>>>  libavcodec/allcodecs.c     |    1 
>>>>  tests/codec-regression.sh  |    4 -
>>>>  tests/lavf-regression.sh   |    2 
>>>>  tests/ref/acodec/ac3       |    2 
>>>>  tests/ref/acodec/ac3_fixed |    2 
>>>>  11 files changed, 184 insertions(+), 10 deletions(-)
>>>> c7d77f0059950939ac2dedeed1047d3d60ffeddc  0002-Add-floating-point-AC-3-encoder.patch
>>>
>>> lgtm if tested
>>
>>
>> Should I also bump lavc minor version since I'm adding a new codec?
> 
> bumping does no harm so when in doubt IMHO do bump


applied. with minor bump.

Thanks,
Justin



More information about the ffmpeg-devel mailing list