[FFmpeg-devel] [PATCH] forward ASF tags to RTSP for MS-RTSP

[Aurelien Jacobs]

On Mon, Jan 03, 2011 at 03:06:20PM -0500, Justin Ruggles wrote:
> On 01/03/2011 01:22 PM, Ronald S. Bultje wrote:
> 
> > Hi,
> > 
> > On Mon, Jan 3, 2011 at 1:17 PM, Martin Storsj? <martin at martin.st> wrote:
> >> On Mon, 3 Jan 2011, Ronald S. Bultje wrote:
> >>
> >>> for chained demuxers, we need to manually FW tags, this patch does it
> >>> for MS-RTSP. Fixes issue 2478.
> >>
> >> Looks good to me.
> >>
> >> As future improvment - should we make this into a reusable function? I
> >> guess something similar might be needed for other
> >> full-container-within-another-container setups (like mpegts in RTP).
> > 
> > Sounds like a good plan - but I'd like to leave that question to other
> > metadata experts. Anton? Aurel? Baptiste? Michael?
> 
> 
> search ffmpeg.c for "autocopy" and you'll find lots of code very similar
> to this.  So adding it to the public API might be a good idea.

I agree that a public metadata_copy API would be useful.
Something like:
    int av_metadata_copy(AVMetadata **dest, AVMetadata *src);
And maybe also:
    int av_metadata_copy_all(AVFormatContext *dest, AVFormatContext *src);

Aurel